RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v4]

[Andrew Haley]

On Fri, 15 Mar 2024 13:58:05 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you help to review this patch?
>> Thanks
>> 
>> This is a continuation of work based on [1] by @XiaohongGong, most work was done in that pr. In this new pr, just rebased the code in [1], then added some minor changes (renaming of calling method, add libsleef as extra lib in CI cross-build on aarch64 in github workflow); I aslo tested the combination of following scenarios:
>> * at build time
>>   * with/without sleef
>>   * with/without sve support 
>> * at runtime
>>   * with/without sleef
>>   * with/without sve support 
>> 
>> [1] https://github.com/openjdk/jdk/pull/16234
>> 
>> ## Regression Test
>> * test/jdk/jdk/incubator/vector/
>> * test/hotspot/jtreg/compiler/vectorapi/
>> 
>> ## Performance Test
>> Previously, @XiaohongGong has shared the data: https://github.com/openjdk/jdk/pull/16234#issuecomment-1767727028
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix jni includes

> > > What is the relevance of SVE support at build time? Should it matter what the build machine is?
> > 
> > 
> > My understanding is that we need a compiler that supports `-march=armv8-a+sve`; otherwise we can't build the redirect library properly. But maybe that is a misunderstanding?
> 
> I hope not, otherwise the resulting binary won't run on most systems.

I can write you a redirect library that doesn't need any magic compiler options.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18294#issuecomment-2014979694