Integrated: 8328679: Improve comment for UNSAFE_ENTRY_SCOPED in unsafe.cpp
Maurizio Cimadamore
mcimadamore at openjdk.org
Fri Mar 22 15:12:25 UTC 2024
On Thu, 21 Mar 2024 11:04:41 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
> This small PR is an attempt at improving the comment in the UNSAFE_ENTRY_SCOPED macro.
> I found that the comment contained some duplicated claims, did not properly introduced the concepts it referred to, and some of its claims were not explained in full.
>
> As this is a delicate part of how FFM ensures the "no use after free" guarantee, I think it would be a good idea for this comment to better reflect what the expectations are.
This pull request has now been integrated.
Changeset: 709410d8
Author: Maurizio Cimadamore <mcimadamore at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/709410d8a4ca176c52d9c0abf80ed59eeb6bdaf3
Stats: 20 lines in 1 file changed: 3 ins; 2 del; 15 mod
8328679: Improve comment for UNSAFE_ENTRY_SCOPED in unsafe.cpp
Reviewed-by: jvernee, dholmes
-------------
PR: https://git.openjdk.org/jdk/pull/18429
More information about the hotspot-dev
mailing list