RFR: 8312132: Add tracking of multiple address spaces in NMT [v5]
Johan Sjölen
jsjolen at openjdk.org
Fri Mar 22 16:28:25 UTC 2024
On Fri, 22 Mar 2024 13:23:22 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Include os.inline.hpp
>
> src/hotspot/share/nmt/nmtTreap.hpp line 45:
>
>> 43: // the tree which is O(log n) so we are safe from stack overflow.
>> 44:
>> 45: // TreapNode has LEQ nodes on the left, GT nodes on the right.
>
> Simplification: why do we need a separate template parameter for the comparison? Why not just use K's operators < > == ?
I tend to not use operator-overloading so I didn't think of that as a possibility.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1535855082
More information about the hotspot-dev
mailing list