RFR: JDK-8180450: secondary_super_cache does not scale well [v5]

Andrew Haley aph at openjdk.org
Fri Mar 22 18:45:29 UTC 2024


On Fri, 22 Mar 2024 18:36:41 GMT, Andrew Haley <aph at openjdk.org> wrote:

>>> I would have liked to save the hashed interfaces list in the CDS archive file, but there are test cases for the Serviceability Agent that assume the interfaces are in the order in which they are declared. I think the tests are probably just wrong about this. For the same reason, I have to make copies of the interfaces array and sort the copies, rather than just using the same array at runtime.
>> 
>> May be file follow up RFE for saving hashed interfaces list in CDS which will also fix those tests.
>
>> > I would have liked to save the hashed interfaces list in the CDS archive file, but there are test cases for the Serviceability Agent that assume the interfaces are in the order in which they are declared. I think the tests are probably just wrong about this. For the same reason, I have to make copies of the interfaces array and sort the copies, rather than just using the same array at runtime.
>> 
>> May be file follow up RFE for saving hashed interfaces list in CDS which will also fix those tests.
> 
> That sounds good.

> @theRealAph I applied your patch and ran SA tests. I did not see the failures you mentioned to me. Is there anything else special I need to do?

I need to prepare you a branch with the feature that does the hashing earlier and saves the hashed secondaries in the CDS archive. Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18309#issuecomment-2015701761


More information about the hotspot-dev mailing list