RFR: 8327652: S390x: Implements SLP support [v5]
Sidraya Jayagond
sjayagond at openjdk.org
Mon Mar 25 11:08:25 UTC 2024
On Fri, 22 Mar 2024 05:23:36 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:
>> Sidraya Jayagond has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Address code cleanup review comments
>
> src/hotspot/cpu/s390/sharedRuntime_s390.cpp line 422:
>
>> 420: map->set_callee_saved(VMRegImpl::stack2reg(offset>>2), RegisterSaver_LiveVRegs[i].vmreg);
>> 421: offset += v_reg_size;
>> 422: }
>
> just in case you like this one.
> Suggestion:
>
> for (int i = 0; i < vregstosave_num; i++, offset += v_reg_size) {
> int reg_num = RegisterSaver_LiveVRegs[i].reg_num;
>
> __ z_vst(as_VectorRegister(reg_num), Address(Z_SP, offset));
>
> map->set_callee_saved(VMRegImpl::stack2reg(offset>>2), RegisterSaver_LiveVRegs[i].vmreg);
> }
This seems more readable code, Fixing it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18162#discussion_r1537411943
More information about the hotspot-dev
mailing list