RFR: JDK-8316991: Reduce nullable allocation merges [v9]
Cesar Soares Lucas
cslucas at openjdk.org
Thu Mar 28 19:59:35 UTC 2024
On Tue, 26 Mar 2024 20:52:09 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:
>> Cesar Soares Lucas has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits:
>>
>> - Merge remote-tracking branch 'origin/master' into ram-nullables
>> - Catching up with master
>> - Fix broken build.
>> - Merge with origin/master
>> - Update test/micro/org/openjdk/bench/vm/compiler/AllocationMerges.java
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>> - Ammend previous fix & add repro tests.
>> - Fix to prevent reducing already reduced Phi
>> - Fix to prevent creating NULL ConNKlass constants.
>> - Refrain from RAM of arrays and Phis controlled by Loop nodes.
>> - Fix typo in test.
>> - ... and 3 more: https://git.openjdk.org/jdk/compare/89e0889a...3129378f
>
> src/hotspot/share/code/debugInfo.hpp line 136:
>
>> 134: Handle _value;
>> 135: bool _visited;
>> 136: bool _was_scalar_replaced; // Whether this ObjectValue describes an object scalar replaced or just
>
> Name it `is_scalar_replaced` maybe?
Good catch
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15825#discussion_r1543569022
More information about the hotspot-dev
mailing list