RFR: 8314225: SIGSEGV in JavaThread::is_lock_owned [v2]

[David Holmes]

On Wed, 1 May 2024 10:00:49 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Removal of JavaThread's MonitorChunks member.  This held lock information during deoptimization, but access to it is unnecessary for anything other than the deoptimization itself.
>> 
>> Access to it in is_lock_owned() was racy, and caused rare crashes.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Feedback from Dean

src/hotspot/share/runtime/javaThread.cpp line 1051:

> 1049:   assert(LockingMode != LM_LIGHTWEIGHT, "should not be called with new lightweight locking");
> 1050:   return Thread::is_lock_owned(adr);
> 1051: }

Can't we just remove `JavaThread::is_lock_owned` now?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18940#discussion_r1586075215