RFR: 8314225: SIGSEGV in JavaThread::is_lock_owned [v3]

Coleen Phillimore coleenp at openjdk.org
Wed May 1 12:10:52 UTC 2024


On Wed, 1 May 2024 11:04:21 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Removal of JavaThread's MonitorChunks member.  This held lock information during deoptimization, but access to it is unnecessary for anything other than the deoptimization itself.
>> 
>> Access to it in is_lock_owned() was racy, and caused rare crashes.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove JavaThread's is_lock_owned

src/hotspot/share/runtime/vframeArray.cpp line 55:

> 53:      MonitorChunk* chunk = _monitors;
> 54:      _monitors = nullptr;
> 55:      delete chunk;

Is there just one monitor now on the vframeArrayElement?  All of these functions imply there are more than one but if I'm reading this right only one gets deleted.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18940#discussion_r1586235275


More information about the hotspot-dev mailing list