RFR: 8314225: SIGSEGV in JavaThread::is_lock_owned [v3]

[Dean Long]

On Wed, 1 May 2024 11:04:21 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Removal of JavaThread's MonitorChunks member.  This held lock information during deoptimization, but access to it is unnecessary for anything other than the deoptimization itself.
>> 
>> Access to it in is_lock_owned() was racy, and caused rare crashes.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove JavaThread's is_lock_owned

src/hotspot/share/runtime/thread.cpp line 530:

> 528: #endif // ASSERT
> 529: 
> 530: bool Thread::is_lock_owned(address adr) const {

Is there any reason not to move this to JavaThread now?  Also, I don't think it needs to be virtual.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18940#discussion_r1586844763