RFR: 8326306: RISC-V: Re-structure MASM calls and jumps [v2]

Robbin Ehn rehn at openjdk.org
Thu May 2 06:50:57 UTC 2024


On Wed, 1 May 2024 08:06:17 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> I am still thinking about the possibility of unifying `call` and `rt_call`. Having both of them could be confusing to me (and new comers I guess). What I was talking about in my previous comment is something like this add-on change:
>> [addon.diff.txt](https://github.com/openjdk/jdk/files/15164874/addon.diff.txt)
>> What do you think?
>
> Off today, I'll have a look tomorrow, thanks.

Yes, we should use is_32bit_offset_from_codecache to use auipc as much as possible.
As there is much churn in this patch and our testing takes so long I was trying to keep assembly same to avoid bisecting down issues.

It's much better with just two calls, either rt call or VM leaf.

I'll test your patch, thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18942#discussion_r1587144634


More information about the hotspot-dev mailing list