RFR: 8330532: Improve line-oriented text parsing in HotSpot [v4]

[Johan Sjölen]

On Thu, 2 May 2024 09:54:32 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - BlockInputStream is used by gtest only, so moved it there
>>  - removed unused set_position(), etc
>>  - removed _must_free
>
> src/hotspot/share/utilities/istream.cpp line 378:
> 
>> 376:   return old_mode;
>> 377: }
>> 378: #endif //ASSERT
> 
> I believe that we have support for `gcov` (grepping for it shows results for a `GCOV_ENABLED` flag), in which case that's what we should use for code coverage instrumentation. So, this should probably be deleted (along with the rest of it).
> 
> It would be best if we got some docs for how to use gcov also, however.

Key is to provide configure with `--enable-native-coverage`.

For `jib` we have `linux-x64-cov`, see https://github.com/openjdk/jdk/blob/master/make/conf/jib-profiles.js

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18833#discussion_r1587552079