RFR: 8312132: Add tracking of multiple address spaces in NMT [v54]

[Johan Sjölen]

On Mon, 29 Apr 2024 16:13:53 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   assert device != nullptr in MemoryFileTracker::instance
>
> src/hotspot/share/nmt/nmtNativeCallStackStorage.hpp line 52:
> 
>> 50:   };
>> 51:   NativeCallStack* put(const NativeCallStack& value) {
>> 52:     int bucket = value.calculate_hash() % nr_buckets;
> 
> `calculate_hash()` is:
> 
> 
>     for (int i = 0; i < NMT_TrackingStackDepth; i++) {
>       hash += (uintptr_t)_stack[i];
>     }
> 
> 
> Wouldn't XOR serve us better here than plain "+" ?

Yes, probably. This would be a separate RFE, however.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1587716835