RFR: 8314225: SIGSEGV in JavaThread::is_lock_owned [v6]
Dean Long
dlong at openjdk.org
Fri May 3 01:52:56 UTC 2024
On Thu, 2 May 2024 19:40:18 GMT, Kevin Walls <kevinw at openjdk.org> wrote:
>> Removal of JavaThread's MonitorChunks member. This held lock information during deoptimization, but access to it is unnecessary for anything other than the deoptimization itself.
>>
>> Access to it in is_lock_owned() was racy, and caused rare crashes.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
>
> monitor->owner() == nullptr handling in fill_in
src/hotspot/share/runtime/javaThread.hpp line 676:
> 674:
> 675: // Fast-locking support (not for LM_LIGHTWEIGHT)
> 676: bool is_lock_owned(address adr) const;
Suggestion:
// Stack-locking support (not for LM_LIGHTWEIGHT)
bool is_lock_owned(address stack_adr) const;
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18940#discussion_r1588598705
More information about the hotspot-dev
mailing list