RFR: 8330532: Improve line-oriented text parsing in HotSpot [v3]

John Rose john.r.rose at oracle.com
Fri May 3 08:16:38 UTC 2024


On 1 May 2024, at 13:30, Ioi Lam wrote:

> I am also leaning towards removing the `close()` call. Otherwise it would be unsymmetrical - the `inputStream` doesn't open the `_input` automatically, but it will close it automatically for us.
>
> It seems better to leave both the `open` and `close` to the caller the `inputStream`.
>
> @rose00 what do you think?

You guys are right; the caller should deal with any “close”.
And that removes the need for a virtual close method, I think?
In which case, yes, ditch close() completely.

The more important API point is set_input.  Glad that’s staying.


More information about the hotspot-dev mailing list