RFR: 8331608: Consolidate EncodeGCModeConcurrentFrameClosure and TransformStackChunkClosure

Stefan Karlsson stefank at openjdk.org
Fri May 3 12:23:52 UTC 2024


On Fri, 3 May 2024 11:58:36 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> After [JDK-8296875](https://bugs.openjdk.org/browse/JDK-8296875), the classes `EncodeGCModeConcurrentFrameClosure` and `TransformStackChunkClosure` almost have the same code. This patch consolidates them into one.
> 
> The tests `make test-hotspot_loom` and `make test-hotspot_gc` passed locally (linux & x64). Thanks for taking the time to review.
> 
> Best Regards,
> -- Guoxiong

There doesn't seem to be a need to place the `derived_cl` closures in the callers. Could you keep it within `do_frame` as we used to do in `TransformStackChunkClosure`?

-------------

Changes requested by stefank (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19084#pullrequestreview-2038024207


More information about the hotspot-dev mailing list