RFR: 8314225: SIGSEGV in JavaThread::is_lock_owned [v8]

Kevin Walls kevinw at openjdk.org
Fri May 3 21:43:09 UTC 2024


> Removal of JavaThread's MonitorChunks member.  This held lock information during deoptimization, but access to it is unnecessary for anything other than the deoptimization itself.
> 
> Access to it in is_lock_owned() was racy, and caused rare crashes.

Kevin Walls has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:

 - Merge remote-tracking branch 'upstream/master' into 8314225_is_lock_owned_no_monitor_chunks_check
 - fill_in assert update
 - JavaThread comment update and synchronizer check before cast
 - monitor->owner() == nullptr handling in fill_in
 - Missing include
 - Move is_lock_owned from Thread to JavaThread
 - Remove JavaThread's is_lock_owned
 - Feedback from Dean
 - Merge remote-tracking branch 'upstream/master' into 8314225_is_lock_owned_no_monitor_chunks_check
 - Add asserts around move_to calls
 - ... and 2 more: https://git.openjdk.org/jdk/compare/d8a4ee4e...b5380800

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18940/files
  - new: https://git.openjdk.org/jdk/pull/18940/files/2989ad4c..b5380800

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18940&range=07
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18940&range=06-07

  Stats: 6408 lines in 269 files changed: 3176 ins; 1347 del; 1885 mod
  Patch: https://git.openjdk.org/jdk/pull/18940.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18940/head:pull/18940

PR: https://git.openjdk.org/jdk/pull/18940


More information about the hotspot-dev mailing list