RFR: 8331626: unsafe.cpp:162:38: runtime error in index_oop_from_field_offset_long - applying non-zero offset 4563897424 to null pointer [v2]

[Stefan Karlsson]

On Mon, 6 May 2024 14:30:53 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> I couldn't find that in the hotspot style guide. Is that documented anywhere? We sometimes use it. Nevertheless, I've changed it.
>
> I think I've read it somewhere, but I can't find it. I would prefer if we didn't use it in shared code.

FWIW, I found that the C++ Core Guidelines mentions this:
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-name-one

So, it could have been there I read it and had it resonate with my view of the HotSpot code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19087#discussion_r1591124541