RFR: 8326306: RISC-V: Re-structure MASM calls and jumps [v5]

Robbin Ehn rehn at openjdk.org
Tue May 7 10:44:04 UTC 2024


On Tue, 7 May 2024 07:25:02 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> I don't find a nice way to get li for them.
>> https://github.com/openjdk/jdk/blob/3b8227ba24c7bc05a8ea23801e3816e8fc80de4e/src/hotspot/cpu/riscv/templateInterpreterGenerator_riscv.cpp#L272
>> 
>> Any suggestions?
>> 
>> As I said, if we want to be performant here we should implement the "StubRoutines::dpow()".
>> 
>> What you think?
>
> Hmm .. It does look bad to me if we use mv instead of movptr like you do in your previous commit [1]. 
> Seems that a mv is more reasonable than movptr in this case when addr is out of code cache, isn't it? 
> And it's not solely about the currently call sites like in the interpreter, we should also consider future possible uses of `call`. 
> 
> (Or keep the old `call` to be conservative for this PR?)
> 
> [1] https://github.com/openjdk/jdk/pull/18942/commits/d8fbb00b51afbf6a3b7dcd828f623b4add949faf

As I can't fix this with a few changes, and I don't want to mess up this PR.
I added check for li directly in the call.
Sanity tested with -XX:ReservedCodeCacheSize=2047M

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18942#discussion_r1592234233


More information about the hotspot-dev mailing list