RFR: 8331098: [Aarch64] Fix crash in Arrays.equals() intrinsic with -CCP [v4]

Roman Kennke rkennke at openjdk.org
Tue May 7 10:58:53 UTC 2024


On Mon, 6 May 2024 12:03:03 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove extra whitespace
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 5770:
> 
>> 5768:     sub(tmp5, zr, cnt1, LSL, 3 + log_elem_size);
>> 5769:     ldr(tmp3, Address(pre(a1, start_offset)));
>> 5770:     ldr(tmp4, Address(pre(a2, start_offset)));
> 
> Is the use of `pre` intentional? If that is the case why would that be better than just a `reg + offset`? (Given that `a1` and `a2` are not used again)

No, this is a copy+paste mistake. Will fix.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18948#discussion_r1592272700


More information about the hotspot-dev mailing list