RFR: 8312132: Add tracking of multiple address spaces in NMT [v46]

[Johan Sjölen]

On Thu, 25 Apr 2024 10:23:35 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> src/hotspot/share/nmt/vmatree.cpp line 242:
>> 
>>> 240:   }
>>> 241:   return diff;
>>> 242: }
>> 
>> Would be nice if we can break this function into some smaller sub-functions. It is 200+ line now and little hard to track the logic. Thanks!
>
> Sure, I think there are a couple of cases which are actual functions (taking input, producing output, nothing else), those can be converted.

I've cleaned up the code a bit. I don't think there's much of a point in hiding the computations behind subfunctions, as it reads from top to bottom.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1592364938