RFR: 8331558: AArch64: optimize integer remainder [v3]

[Bhavana Kilambi]

On Wed, 8 May 2024 01:04:37 GMT, Jin Guojie <duke at openjdk.org> wrote:

>> 8331558: AArch64: optimize integer remainder
>>     On some Arm processors, a separate multiply/subtract is actually faster than the combined instruction.
>> 
>> 8331556: AArch64: CPU_Model support for Neoverse N1/N2/V1/V2
>>     Add full platform coverage for Neoverse variants in vm_version.?pp
>> 
>> The following test has passed, which shows definite performance improvement.
>> 
>> make test TEST="micro:java.lang.IntegerDivMod"
>> make test TEST="micro:java.lang.LongDivMod"
>> 
>> * IntegerDivMod.testDivideRemainderUnsigned
>> baseline(ns/ops)                2223
>> with this pacth(ns/ops)         1885    
>> improvement(%)                  17.93%
>> 
>> * IntegerDivMod.testRemainderUnsigned
>> baseline(ns/ops)                2225
>> with this pacth(ns/ops)         1885    
>> improvement(%)                  18.03%
>> 
>> * LongDivMod.testDivideRemainderUnsigned
>> baseline(ns/ops)                2231
>> with this pacth(ns/ops)         1894    
>> improvement(%)                  17.79%
>> 
>> * LongDivMod.testRemainderUnsigned
>> baseline(ns/ops)                2232
>> with this pacth(ns/ops)         1891
>> improvement(%)                  18.03%
>
> Jin Guojie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Applicable platforms expanded to the entire neoverse family
>   
>   Even on the V series (V1 and V2), both sdiv/udiv and msub instructions are executed in M0 unit (Integer multi cycle). It should benefit the V series as well.

src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp line 448:

> 446:     if (VM_Version::supports_a53mac() && Ra != zr)
> 447:       nop();
> 448:     if (VM_Version::is_neoverse_family()) {

Thanks for changing. However, currently neoverse_family includes N1,N2,V1 and V2 for which this change is ok but eventually when support is added for next versions of N/V series which do not require splitting `msub` into `mul` and `sub` (for ex. V3) then this check will have to be modified as V3 will need to be included in the "neoverse_family". Maybe a separate function here which checks for only those N/V series where this change will benefit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19093#discussion_r1593664033