RFR: 8314225: SIGSEGV in JavaThread::is_lock_owned [v6]
Kevin Walls
kevinw at openjdk.org
Wed May 8 11:16:57 UTC 2024
On Fri, 3 May 2024 02:20:34 GMT, Dean Long <dlong at openjdk.org> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
>>
>> monitor->owner() == nullptr handling in fill_in
>
> src/hotspot/share/runtime/vframeArray.cpp line 97:
>
>> 95: dest->set_obj(nullptr);
>> 96: } else {
>> 97: assert(!monitor->owner()->is_unlocked(), "object must be null or locked");
>
> Suggestion:
>
> assert(monitor->owner() != nullptr, "monitor owner must not be null");
> assert(!monitor->owner()->is_unlocked(), "monitor must be locked");
Yes, done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18940#discussion_r1593858530
More information about the hotspot-dev
mailing list