RFR: 8322753: RISC-V: C2 ReverseBytesV [v3]

Hamlin Li mli at openjdk.org
Wed May 8 12:52:10 UTC 2024


On Wed, 8 May 2024 10:55:22 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix merge
>
> src/hotspot/cpu/riscv/riscv_v.ad line 3766:
> 
>> 3764:   format %{ "vector_reverse_byte $dst, $src, v0.t" %}
>> 3765:   ins_encode %{
>> 3766:     __ vrev8_v(as_VectorRegister($dst$$reg), as_VectorRegister($src$$reg), __ VectorMask::v0_t);
> 
> I think we should call `vsetvli_helper(bt, vlen)` for both newly-added instructs. Also, can we use `Assembler::v0_t` instead of `__ VectorMask::v0_t` here like you do in https://github.com/openjdk/jdk/pull/19065 for consistency?

Thanks for catching!

Others are also fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19120#discussion_r1593977034


More information about the hotspot-dev mailing list