RFR: 8322753: RISC-V: C2 ReverseBytesV [v5]

[Fei Yang]

On Wed, 8 May 2024 12:52:10 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you review this patch to add ReverseBytesV intrinsic?
>> Thanks.
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor

Thanks for the quick update. LGTM.

src/hotspot/cpu/riscv/riscv_v.ad line 3771:

> 3769:     __ vrev8_v(as_VectorRegister($dst$$reg), as_VectorRegister($src$$reg), Assembler::v0_t);
> 3770:   %}
> 3771:   ins_pipe( pipe_slow );

Nit: Better to remove redundant the spaces around pipe_slow.

src/hotspot/cpu/riscv/riscv_v.ad line 3783:

> 3781:     __ vrev8_v(as_VectorRegister($dst$$reg), as_VectorRegister($src$$reg));
> 3782:   %}
> 3783:   ins_pipe( pipe_slow );

Similar here.

-------------

Marked as reviewed by fyang (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19120#pullrequestreview-2045642522
PR Review Comment: https://git.openjdk.org/jdk/pull/19120#discussion_r1594021889
PR Review Comment: https://git.openjdk.org/jdk/pull/19120#discussion_r1594022483