RFR: 8312132: Add tracking of multiple address spaces in NMT [v74]

[Thomas Stuefe]

On Thu, 9 May 2024 11:22:30 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Some style
>
> test/hotspot/gtest/nmt/test_nmt_treap.cpp line 57:
> 
>> 55:       treap.remove(i);
>> 56:     }
>> 57:   }
> 
> Please test the find functions (leq, geq etc) and iteration.
> 
> For the latter, please test that we see every value, guaranteed, and that we see every value only exactly once.
> 
> Also test:
> - inserting duplicates should result in only one value
> - empty treap should work as expected
> - treap with custom allocator, e.g. a simple array based one. Make sure we don't leak memory after nodes are removed, or after remove_all
> - treap with different custom comparator, please counter check the iteration order
> - maybe some more types? at least the common numericals

And I would not rely on the internal verification here, but call verify explicitly. (see also note in treap add/remove about verification)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1595324461