RFR: 8331558: AArch64: optimize integer remainder [v8]

Jin Guojie duke at openjdk.org
Fri May 10 02:24:05 UTC 2024


On Thu, 9 May 2024 16:10:37 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Jin Guojie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Refine comments
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp line 472:
> 
>> 470:     }
>> 471:   }
>> 472: 
> 
> OK, I'm happy to approve this, but these functions are too big now to be inlined. Please put them in macroAssembler_aarch64.cpp and we're done. Thanks.

Done in these commits:

https://github.com/openjdk/jdk/pull/19093/commits/e54be61f8c5cb6d95908e7435be5eb85b5df65fd

https://github.com/openjdk/jdk/pull/19093/commits/2a16eba516ab7ff9b90f9a2d27dc63cf5a90015b

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19093#discussion_r1596177452


More information about the hotspot-dev mailing list