RFR: 8326306: RISC-V: Re-structure MASM calls and jumps [v10]

[Robbin Ehn]

On Fri, 10 May 2024 07:56:06 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into jal-fixes
>>  - Revert JNI field, call()->li()
>>  - Use li instead of movptr for call
>>  - REVERT: Use li instead of movptr
>>  - Use li instead of movptr
>>  - VM leaf should use li
>>  - Merge branch 'master' into jal-fixes
>>  - Merge branch 'master' into jal-fixes
>>  - Merge branch 'master' into jal-fixes
>>  - Corrected method name
>>  - ... and 2 more: https://git.openjdk.org/jdk/compare/4aeaf336...d53e9694
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 653:
> 
>> 651:   push_reg(RegSet::of(t0, xmethod), sp);   // push << t0 & xmethod >> to sp
>> 652:   mv(t0, entry_point, offset);
>> 653:   Assembler::jalr(x1, t0, offset);
> 
> You might want a `jalr(t0, offset)` here?
> 
> (I also see serveral other occurrences of `Assembler::jalr(Register Rd, Register Rs, const int32_t offset)` like in `MacroAssembler::call`. Is there a reason to not use `MacroAssembler::jalr(Register Rs, int32_t offset)` for those places?)

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18942#discussion_r1597927063