RFR: 8312132: Add tracking of multiple address spaces in NMT [v67]
Johan Sjölen
jsjolen at openjdk.org
Mon May 13 06:34:14 UTC 2024
On Tue, 7 May 2024 13:40:07 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Johan Sjölen has updated the pull request incrementally with four additional commits since the last revision:
>>
>> - Remove GEQ_B
>> - Move things around slightly to be closer to usage
>> - Simplify code
>> - Remove superfluous comment
>
> src/hotspot/share/nmt/nmtTreap.hpp line 66:
>
>> 64: _right(nullptr) {
>> 65: }
>> 66:
>
> condense this code a little? Getters can be one-liners
I personally prefer it being non-condensed, but Afshin also mentioned this so I consider myself over-ruled :).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1597939452
More information about the hotspot-dev
mailing list