RFR: 8312132: Add tracking of multiple address spaces in NMT [v74]

Johan Sjölen jsjolen at openjdk.org
Mon May 13 06:54:12 UTC 2024


On Thu, 9 May 2024 11:04:41 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Some style
>
> src/hotspot/share/nmt/nmtTreap.hpp line 287:
> 
>> 285:     if (leqB != nullptr && leqB->key() == key) {
>> 286:       return leqB;
>> 287:     }
> 
> I don't get this, why is this leq search needed? And if its needed, is that not redundant to the code below that compares for key equality?

Hi, this function is deleted as it's no longer in use.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1597957808


More information about the hotspot-dev mailing list