RFR: 8312132: Add tracking of multiple address spaces in NMT [v74]

Johan Sjölen jsjolen at openjdk.org
Mon May 13 10:30:17 UTC 2024


On Fri, 10 May 2024 11:58:42 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Some style
>
> src/hotspot/share/nmt/vmatree.cpp line 156:
> 
>> 154:   if (to_be_deleted_inbetween_a_b.length() == 0 && LEQ_A_found) {
>> 155:     // We must have smashed a hole in an existing region (or replaced it entirely).
>> 156:     // LEQ_A - A - B - (some node >= B)
> 
> nit, clearer comment (a bit) since at first glance looks like substraction: `LEQ_A < A < B < (some node >= B)`. Alternatively, `LEQ_A [A, B) C`

`// LEQ_A < A < B <= C`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1598243943


More information about the hotspot-dev mailing list