RFR: 8312132: Add tracking of multiple address spaces in NMT [v74]

Johan Sjölen jsjolen at openjdk.org
Tue May 14 16:23:26 UTC 2024


On Mon, 13 May 2024 12:51:45 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Afshin mentioned this too, I believe, but I want to push back here. I prefer showing what we're doing here (simple comparison) rather than hiding it behind a utility function. Requires less jumping around when reading unknown code.
>
> Tiny utility functions like this are effectively resolved in modern C++ IDEs like CDS. (In stark contrast to templates, which make IDEs very confused). And a clear name provides safety against accidental typos.
> 
> I leave this up to you.

Thanks, leaving them as they are. Even with jump-to-def, it bothers me :-). I might be the only one.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1600322153


More information about the hotspot-dev mailing list