RFR: 8331193: Return references when possible in GrowableArray [v6]

[Johan Sjölen]

On Tue, 21 May 2024 13:18:35 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Can you add a regression test that checks exactly the example that you have in your PR descrition?
>
>> Can you add a regression test that checks exactly the example that you have in your PR descrition?
> 
> Hi Emanuel,
> 
> I've been thinking about this a bit. We can add such a test, but it would essentially be a test that checks whether something compiles or not (which it trivially should). We can still add the test you suggested if you feel it is necessary, but it doesn't seem to me like it adds much value?
> 
> Cheers,
> Johan

> @jdksjolen I mean we already test the other methods, so why not test this one? And it is not just about compilation working, but also the results that the new methods return.
> 
> If @stefank @kimbarrett say this is not necessary, then ignore this. Not sure how rigorous they want GrowableArray tested.

Alright, I'll add a couple of tests and ping you for review on them :).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18975#issuecomment-2122873912