RFR: 8332265: RISC-V: Materialize pointers faster by using a temp register [v2]
Fei Yang
fyang at openjdk.org
Wed May 22 06:57:08 UTC 2024
On Tue, 21 May 2024 07:58:33 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:
>> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 1426:
>>
>>> 1424: }
>>> 1425:
>>> 1426: static int patch_addr_in_movptr2(address instruction_address, address target) {
>>
>> Can we have a common entry of `patch_addr_in_movptr` which delegates work to `patch_addr_in_movptr1` and `patch_addr_in_movptr2`?
>
> I think it makes sense to split them up as the difference between movptr1 and movptr2 is already done in the caller then. And IIUC we don't plan to merge movptr1 and movptr2 together at any point, so we don't particularly need to abstract them away.
All right. I can live with this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19246#discussion_r1609385061
More information about the hotspot-dev
mailing list