RFR: 8329748: Change default value of AssertWXAtThreadSync to true

Tobias Holenstein tholenstein at openjdk.org
Wed May 22 08:53:10 UTC 2024


On Mon, 6 May 2024 16:52:19 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> The debug flag `-XX:+AssertWXAtThreadSync` conservatively  checks for correct W^X thread state at possible safepoints or handshake. The flag is useful to detect missing `MACOS_AARCH64_ONLY(ThreadWXEnable __wx(WXWrite, thread));`. Since the check is cheap and it is a `AARCH64_ONLY(develop(..))` only flag it makes sense to enable the flag by default. 
>> 
>> There was one missing `MACOS_AARCH64_ONLY(ThreadWXEnable __wx(WXWrite, thread));` to make all tests (tier1-7) pass.
>
> Good.

Thanks for the reviews @vnkozlov , @reinrich and @dean-long

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19102#issuecomment-2124223006


More information about the hotspot-dev mailing list