RFR: 8325821: [REDO] use "dmb.ishst+dmb.ishld" for release barrier [v2]

kuaiwei duke at openjdk.org
Wed May 22 11:15:02 UTC 2024


On Wed, 22 May 2024 10:25:40 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> kuaiwei has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make MacroAssembler::merge more clear
>
> test/hotspot/gtest/aarch64/test_assembler_aarch64.cpp line 198:
> 
>> 196: }
>> 197: 
>> 198: TEST_VM(AssemblerAArch64, merge_ldst) {
> 
> This test seems to be irrelevant for the issue at hand? Tests `ld/st` -> `ldp/stp` merging, not the barrier merges?

In this patch, I fixed an issue, dmb/st/ld may not merge if CodeBuffer is expanding, I added some unit tests to check it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19278#discussion_r1609764081


More information about the hotspot-dev mailing list