RFR: 8312132: Add tracking of multiple address spaces in NMT [v97]
Gerard Ziemski
gziemski at openjdk.org
Wed May 22 17:21:21 UTC 2024
On Tue, 21 May 2024 14:51:40 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:
>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix copyright
>
> src/hotspot/share/nmt/nmtTreap.hpp line 236:
>
>> 234: }
>> 235:
>> 236: void upsert(const K& k, const V& v) {
>
> Could we rename this to simply `add()` instead of `upsert()` ?
I would take `insert()` over `upsert()` too, if you don't like `add()` :-)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1610374113
More information about the hotspot-dev
mailing list