RFR: 8332265: RISC-V: Materialize pointers faster by using a temp register [v4]

[Robbin Ehn]

On Wed, 22 May 2024 12:43:50 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
>> 
>>  - Review changes
>>  - Merge branch 'master' into 8332265
>>  - Merge branch 'master' into 8332265
>>  - Small review update
>>  - li48 -> movptr
>>  - Merge branch 'master' into 8332265
>>  - li48
>
> src/hotspot/cpu/riscv/nativeInst_riscv.hpp line 141:
> 
>> 139:   //     add
>> 140:   //     addi/jalr/load
>> 141:   static bool check_movptr2_data_dependency(address instr) {
> 
> Better to rename the existing `check_movptr_data_dependency` as `check_movptr1_data_dependency` at the same time.

Fixed

> src/hotspot/cpu/riscv/nativeInst_riscv.hpp line 421:
> 
>> 419:   void flush() {
>> 420:     if (!maybe_cpool_ref(instruction_address())) {
>> 421:       ICache::invalidate_range(instruction_address(), movptr1_instruction_size /* > movptr2_instruction_size */);
> 
> Maybe we can simply remove this `flush()` member function which is not used anywhere.

Fixed

> src/hotspot/cpu/riscv/riscv.ad line 1289:
> 
>> 1287: {
>> 1288:   // skip the movptr2 in MacroAssembler::ic_call():
>> 1289:   // lui + addi + slli + addi + slli + addi
> 
> You might also want to update this instruction sequence in the code comment to reflect `movptr2()`.

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19246#discussion_r1610475284
PR Review Comment: https://git.openjdk.org/jdk/pull/19246#discussion_r1610474893
PR Review Comment: https://git.openjdk.org/jdk/pull/19246#discussion_r1610475031