RFR: 8332724: x86 MacroAssembler may over-align code [v2]

[Daniel Jeliński]

On Wed, 22 May 2024 22:12:38 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Daniel Jeliński has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Explicit typecasts
>>  - Change to unsigned instead
>
> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 1166:
> 
>> 1164: }
>> 1165: 
>> 1166: void MacroAssembler::align(int modulus, int target) {
> 
> How about making both parameters unsigned?
> And callers could be changed to something like:
> 
> align(64, (uint)(uintptr_t)pc() & 63);

Good idea. It also fixes a couple of conversion warnings. Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19353#discussion_r1611321244