RFR: 8332265: RISC-V: Materialize pointers faster by using a temp register [v6]

Robbin Ehn rehn at openjdk.org
Thu May 23 10:55:36 UTC 2024


On Thu, 23 May 2024 10:50:32 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fixed more comments
>>  - Fixed comments
>
> src/hotspot/cpu/riscv/nativeInst_riscv.hpp line 386:
> 
>> 384:   void set_data(intptr_t x);
>> 385: 
>> 386:   void flush() {
> 
> why the removal?

It was unused, and I had review comment in there.
It was suggested to be removed instead of fixing the comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19246#discussion_r1611460936


More information about the hotspot-dev mailing list