RFR: 8325821: [REDO] use "dmb.ishst+dmb.ishld" for release barrier [v2]
Aleksey Shipilev
shade at openjdk.org
Thu May 23 10:58:04 UTC 2024
On Thu, 23 May 2024 05:53:25 GMT, kuaiwei <duke at openjdk.org> wrote:
>> test/hotspot/gtest/aarch64/test_assembler_aarch64.cpp line 93:
>>
>>> 91: }
>>> 92:
>>> 93: TEST_VM(AssemblerAArch64, merge_dmb) {
>>
>> Given the previous experience with barrier merges that prompted the backout, I would prefer to have a more comprehensive test here, maybe an additional one. I am thinking something like the exhaustive combination of 4 back-to-back barriers of each of 5 types. This gives us 5^4 = 625 test cases, which I think is still manageable.
>
> Test is added as merge_dmb_all_kinds
Right. I was implicitly thinking that we can do this without coding the explicit patterns into the test. As it stands now, it is hard to check that generated patterns are actually correct. Let me see if I can whip up a sample of what I had in mind.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19278#discussion_r1611466284
More information about the hotspot-dev
mailing list