RFR: 8312132: Add tracking of multiple address spaces in NMT [v95]

Johan Sjölen jsjolen at openjdk.org
Thu May 23 15:08:15 UTC 2024


On Tue, 21 May 2024 06:18:53 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - Remove unused include
>>  - Basic tests for NativeCallStackStorage
>>  - Allow for passing in nr of buckets
>>  - Remove friend-ness
>
> test/hotspot/gtest/nmt/test_nmt_treap.cpp line 81:
> 
>> 79:     }
>> 80:   }
>> 81: 
> 
> All nodes are same-sized, no? So we don't have to track individual allocations. We can just count them. In the end, counter must be 0.

I don't get how the size matters, but I just added a counter. Fixed!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1611870501


More information about the hotspot-dev mailing list