RFR: 8312132: Add tracking of multiple address spaces in NMT [v105]

Johan Sjölen jsjolen at openjdk.org
Thu May 23 16:25:14 UTC 2024


On Thu, 23 May 2024 05:38:44 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Lower number of pages
>
> test/hotspot/gtest/nmt/test_vmatree.cpp line 70:
> 
>> 68:   NativeCallStackStorage ncs(true);
>> 69:   NativeCallStackStorage::StackIndex si1 = ncs.push(stack1);
>> 70:   NativeCallStackStorage::StackIndex si2 = ncs.push(stack2);
> 
> Should be provided by the fixup class, or as global statics.

Doing this through the usage of a fixture class.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1611989223


More information about the hotspot-dev mailing list