RFR: 8330198: Add some class loading related perf counters to measure VM startup [v3]

[Calvin Cheung]

On Thu, 23 May 2024 22:19:46 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/hotspot/share/classfile/classLoader.cpp line 1477:
>> 
>>> 1475: 
>>> 1476: jlong ClassLoader::class_init_count() {
>>> 1477:   return (UsePerfData) ? _perf_classes_inited->get_value() : -1;
>> 
>> No need to add brackets here
>
> Surely this needs to be checking `ProfileClassLinkage`, which in turn should be false if `UsePerfData` is false.

If `UsePerfData` is set to false, `ProfileClassLinkage` is set to false in arguments.cpp:


3761   if (ProfileClassLinkage && !UsePerfData) {
3762     if (!FLAG_IS_DEFAULT(ProfileClassLinkage)) {
3763        warning("Disabling ProfileClassLinkage since UsePerfData is turned off.");
3764        FLAG_SET_DEFAULT(ProfileClassLinkage, false);
3765      }
3766   }


I will remove the extra parentheses.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18790#discussion_r1612774406