RFR: 8312132: Add tracking of multiple address spaces in NMT [v105]
Thomas Stuefe
stuefe at openjdk.org
Fri May 24 06:28:13 UTC 2024
On Thu, 23 May 2024 16:39:40 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> This doesn't really test the state, nor the stack. It also seems to be a lot of code for a single-use test. Similar in other tests.
> Sorry, I don't understand what you mean by this.
You test that after committing, we have four nodes. You don't test that we have reserved-committed-reserved, nor the associated stacks (all equal), nor the flags. The test would be more interesting if you were to verify the region data, too.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1612895057
More information about the hotspot-dev
mailing list