RFR: 8325821: [REDO] use "dmb.ishst+dmb.ishld" for release barrier [v2]

kuaiwei duke at openjdk.org
Fri May 24 10:06:17 UTC 2024


On Thu, 23 May 2024 16:02:21 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Right. I was implicitly thinking that we can do this without coding the explicit patterns into the test. As it stands now, it is hard to check that generated patterns are actually correct. Let me see if I can whip up a sample of what I had in mind.
>
> I was thinking about this: [improve-tests.patch](https://github.com/openjdk/jdk/files/15419452/improve-tests.patch). Note how it uses the constants for better readability, and also runs the test in both `AlwaysMergeDMB` modes. You might want to adapt other tests to similar pattern.

Thanks for your patch. I patched and add few sanity check.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19278#discussion_r1613219759


More information about the hotspot-dev mailing list