RFR: 8312132: Add tracking of multiple address spaces in NMT [v105]

Johan Sjölen jsjolen at openjdk.org
Fri May 24 12:26:16 UTC 2024


On Fri, 24 May 2024 08:02:03 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Lower number of pages
>
> src/hotspot/share/nmt/memoryFileTracker.cpp line 50:
> 
>> 48:   for (int i = 0; i < mt_number_of_types; i++) {
>> 49:     VirtualMemory* summary = device->_summary.by_type(NMTUtil::index_to_flag(i));
>> 50:     summary->reserve_memory(diff.flag[i].reserve);
> 
> Why do we only track reserved memory here?

This is clearly a point of confusion, as Gerard also asked about this. The answer is that the MFT only cares about memory in a file, which is always considered committed... So we consider reserved memory to be committed. Yeah, let's just change it so that MFT always commits memory instead.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1613395782


More information about the hotspot-dev mailing list