RFR: 8332894: ubsan: vmError.cpp:2090:26: runtime error: division by zero [v2]

[Kim Barrett]

On Mon, 27 May 2024 12:12:39 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Hi David, so the comment
>> 
>> // OSX implements raise(sig) incorrectly so we need to
>> // explicitly target the current thread
>> 
>> seems to be not correct, should we change it e.g. to your comment 
>> 
>> 
>> // macOS raise raises the signal to the process not the thread (per Posix requirements)
>> // so we need to explicitly target the current thread
>
> The comment says raise is broken, it just doesn't say exactly  how, though it is implied by the "we need to explicitly target the current thread".

It's not "broken".  OSX/darwin is BSD-derived, and does not always follow POSIX.
https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man3/raise.3.html
"The raise() function sends the signal sig to the current process."

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19394#discussion_r1616372058