RFR: 8312132: Add tracking of multiple address spaces in NMT [v105]

[Johan Sjölen]

On Fri, 24 May 2024 07:55:31 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Lower number of pages
>
> src/hotspot/share/nmt/memoryFileTracker.cpp line 72:
> 
>> 70:       return;
>> 71:     }
>> 72:     assert(prev->val().out.type() == current->val().in.type(), "must be");
> 
> Slight modification, since I expect we will stare at the output of this function to analyse broken trees. Please keep record of "brokenness" and assert at the end only. And print out the current number of the mapping, too. Then, on assert, print out "tree broken first at record XXX".

I had a go at this. Could you take a look and see if it seems reasonable?

> test/hotspot/gtest/nmt/test_nmt_memoryfiletracker.cpp line 53:
> 
>> 51: TEST_VM_F(MemoryFileTrackerTest, Basics) {
>> 52:   this->basics();
>> 53: }
> 
> Curious, just a question. You like using fixture classes even if not necessary. Why not write the test directly into a TEST_VM ?

Negligible cost, more often than not it turns out that I need the fixture anyway.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1617214510
PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1617209949