RFR: 8325821: [REDO] use "dmb.ishst+dmb.ishld" for release barrier [v2]

Aleksey Shipilev shade at openjdk.org
Wed May 29 11:16:04 UTC 2024


On Wed, 22 May 2024 11:05:49 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> kuaiwei has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make MacroAssembler::merge more clear
>
> Cursory review:

> This looks ready to me. I think we need jcstress with C1 and C2, and we should be done. @shipilev , do you agree?

Yes. Just run jcstress with defaults, maybe limiting the time budget to about 24 hours, and we are done. Default configuration would work through different combinations of C1/C2 compilations for all actors, which is what we want to check for this change: that we don't mess up the barrier emitting scheme in different compilers/interpreters.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19278#issuecomment-2137157664


More information about the hotspot-dev mailing list