RFR: 8332899: RISC-V: add comment and make the code more readable (if possible) in MacroAssembler::movptr

Robbin Ehn rehn at openjdk.org
Fri May 31 13:11:04 UTC 2024


On Tue, 28 May 2024 15:36:00 GMT, Hamlin Li <mli at openjdk.org> wrote:

> Hi,
> Can you help to review the patch?
> As discussed, https://github.com/openjdk/jdk/pull/19246#discussion_r1613279908, it's worth to make the code more readable.
> For movptr1, add some comments to help understand the tricky part.
> For movptr2, it uses the similar (tricky) way as movptr1, so I align the code implementation with movptr1, and try to make it more straightforward.
> I tried it, hope it's better.
> Thanks.

Seems fine to me!

-------------

Marked as reviewed by rehn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19431#pullrequestreview-2090794567


More information about the hotspot-dev mailing list